Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the otel-collector example #2238

Closed
rakyll opened this issue Sep 13, 2021 · 5 comments · Fixed by #5244
Closed

Simplify the otel-collector example #2238

rakyll opened this issue Sep 13, 2021 · 5 comments · Fixed by #5244
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pkg:example Related to an example

Comments

@rakyll
Copy link
Contributor

rakyll commented Sep 13, 2021

The otel-collector example is doing too much to be an entry level example. It'd great to keep the scope to just export OTLP to a collector running locally (via Docker) to provide an easy to setup entry point to developers.

@rakyll rakyll added the bug Something isn't working label Sep 13, 2021
@hanyuancheung
Copy link
Member

Is this issue still need to be improved? I'd like to take it as below:

  • Keep the former k8s setup example.
  • Add a Docker example to export OTLP to a collector running locally by using docker-compose.

@rakyll thx.

@MrAlias MrAlias added this to Needs triage in Bugs via automation Oct 15, 2021
@MrAlias MrAlias added enhancement New feature or request pkg:example Related to an example labels Oct 15, 2021
@MrAlias MrAlias removed this from Needs triage in Bugs Oct 15, 2021
@MrAlias MrAlias removed the bug Something isn't working label Oct 15, 2021
@MrAlias MrAlias added help wanted Extra attention is needed good first issue Good for newcomers labels May 3, 2022
@drichards188
Copy link

Am I correct in my understanding that #2962 was closed and not accepted because of the name logger, and that it's a new example, instead of altering the original otel-collector example?

Is moving from microk8s to Docker to host the collector desirable, or is it best to retain the microk8s deployment and just simplify it?

@MrAlias
Copy link
Contributor

MrAlias commented Jul 19, 2022

Am I correct in my understanding that #2962 was closed and not accepted because of the name logger, and that it's a new example, instead of altering the original otel-collector example?

Is moving from microk8s to Docker to host the collector desirable, or is it best to retain the microk8s deployment and just simplify it?

+1 moving to just Docker and docker compose like the other instrumentation examples (e.g. https://github.com/open-telemetry/opentelemetry-go-contrib/blob/e2cab2e7ca4271c0d6474071a7ce48c0c274e840/instrumentation/github.com/gorilla/mux/otelmux/example/docker-compose.yml) do.

@amila-ku
Copy link

@MrAlias i would like to work on this if this is still needed(quick check at the examples gives the idea it yet to be completed).

If so i would modify the example to remove existing k8s deployment step and replace it with a docker compose based example.

@parauliya
Copy link

Hi @MrAlias ,
I would like to work on it, if this is still needed.
Could you please confirm that the above PR #3560 is in process for merging or is being rejected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pkg:example Related to an example
Projects
None yet
7 participants