Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker compose in otel collector example #5244

Merged
merged 15 commits into from May 2, 2024

Conversation

XSAM
Copy link
Member

@XSAM XSAM commented Apr 20, 2024

resolves #2238

It may supersede #3560 due to the lack of updates for a year.

This PR uses the docker compose to replace the k8s in the otel-collector example.

After this PR, the environment can be brought by only two steps:

  • Have the docker compose installed.
  • Run docker compose up -d

Prior art

https://github.com/XSAM/otelsql/tree/main/example/otel-collector

@XSAM XSAM requested a review from pellared April 26, 2024 21:05
@XSAM XSAM requested a review from dmathieu May 2, 2024 00:37
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.5%. Comparing base (7ee6ff1) to head (c9de802).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5244   +/-   ##
=====================================
  Coverage   84.5%   84.5%           
=====================================
  Files        265     265           
  Lines      17523   17523           
=====================================
+ Hits       14807   14809    +2     
+ Misses      2407    2405    -2     
  Partials     309     309           

see 1 file with indirect coverage changes

@MrAlias MrAlias merged commit dbfc758 into open-telemetry:main May 2, 2024
27 checks passed
@MrAlias MrAlias added this to the v1.27.0 milestone May 2, 2024
@XSAM XSAM deleted the otel-collector-example branch May 2, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the otel-collector example
6 participants