Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTracing Bridge: allow more generic carriers #2141

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

OpenTracing Bridge: allow more generic carriers #2141

wants to merge 6 commits into from

Commits on Apr 16, 2022

  1. OpenTracing Bridge: allow more generic carriers 

    Instead of insisting that the carrier is an HTTPHeaders, cast it
or adapt it to the interface we need - TextMapCarrier.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
    @bboreham
    bboreham committed Apr 16, 2022
    Copy the full SHA
    2ef8a2e View commit details
    Browse the repository at this point in the history

  2. Improve comment 

    Suggested by Tyler Yahn <MrAlias@users.noreply.github.com>

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
    @bboreham
    bboreham committed Apr 16, 2022
    Copy the full SHA
    875cadf View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2022

  1. Add test for BridgeTracer Inject and Extract 

    Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
    @bboreham
    bboreham committed Apr 18, 2022
    Copy the full SHA
    0e16e36 View commit details
    Browse the repository at this point in the history

  2. Special-case extract from ot.HTTPHeadersCarrier 

    Values stored in http.Header get title-cased, i.e. `traceparent` will
turn into `Traceparent`. Since HTTPHeadersCarrier.ForeachKey does not
undo this change, special-case that one type with a different wrapper
that will allow the value to be fetched.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
    @bboreham
    bboreham committed Apr 18, 2022
    Copy the full SHA
    fcb9b2a View commit details
    Browse the repository at this point in the history

  3. Add test for textMapAdapter.Keys 

    This is not currently used in normal functioning of Inject and Extract,
but might get used in future so give it some testing now.

Test adapted from `open-telemetry/opentelemetry-go/propagation/propagation_test.go`

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
    @bboreham
    bboreham committed Apr 18, 2022
    Copy the full SHA
    344c66b View commit details
    Browse the repository at this point in the history

  4. Lint 

    Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
    @bboreham
    bboreham committed Apr 18, 2022
    Copy the full SHA
    8c48780 View commit details
    Browse the repository at this point in the history