Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: support GH page links to canonical src #2189

Merged
merged 1 commit into from Aug 18, 2021

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Aug 17, 2021

Contributes to open-telemetry/opentelemetry.io#542

/cc @carlosalberto @mtwo @shelbyspees @austinlparker

While I can't (currently) show you a preview of this PR, you can see the corresponding change for OTel Java (open-telemetry/opentelemetry-java#3501) in action by trying the Edit this page and related links, from https://opentelemetry.io/docs/java/ and it's subpages.

@Aneurysm9 @MrAlias: I see that this repo doesn't yet have a docs-update GitHub action. I'm going to try an alternative approach that doesn't require an action. If it doesn't work, or isn't approved, I'll submit a docs-update workflow (and get an appropriate token) -- FYI.

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2189 (6786f86) into main (6da20a2) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2189   +/-   ##
=====================================
  Coverage   72.8%   72.8%           
=====================================
  Files        177     177           
  Lines      12151   12151           
=====================================
+ Hits        8852    8855    +3     
+ Misses      3060    3058    -2     
+ Partials     239     238    -1     
Impacted Files Coverage Δ
...s/otlp/otlptrace/internal/connection/connection.go 16.4% <0.0%> (+1.5%) ⬆️

@Aneurysm9 Aneurysm9 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 18, 2021
@MrAlias MrAlias added the documentation Provides helpful information label Aug 18, 2021
@MrAlias MrAlias merged commit c885435 into open-telemetry:main Aug 18, 2021
@chalin chalin deleted the chalin-gh-repo-link-2021-08-17 branch August 18, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants