Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate InstrumentationLibrary from metric.Descriptor #2197

Merged
merged 46 commits into from Sep 27, 2021
Merged

Separate InstrumentationLibrary from metric.Descriptor #2197

merged 46 commits into from Sep 27, 2021

Commits on Aug 18, 2021

  1. factor instrumentation library out of the instrument descriptor

    @jmacd
    jmacd committed Aug 18, 2021
    Copy the full SHA
    cf7e04c View commit details
    Browse the repository at this point in the history

  2. SDK tests pass

    @jmacd
    jmacd committed Aug 18, 2021
    Copy the full SHA
    b016889 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2021

  1. checkpoint work

    @jmacd
    jmacd committed Aug 19, 2021
    Copy the full SHA
    5ab49d1 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. otlp and opencensus tests passing

    @jmacd
    jmacd committed Aug 20, 2021
    Copy the full SHA
    5b9625f View commit details
    Browse the repository at this point in the history

  2. prometheus

    @jmacd
    jmacd committed Aug 20, 2021
    Copy the full SHA
    72e8439 View commit details
    Browse the repository at this point in the history

  3. tests pass, working on lint

    @jmacd
    jmacd committed Aug 20, 2021
    Copy the full SHA
    198f350 View commit details
    Browse the repository at this point in the history

  4. lint applied: MetricReader->Reader

    @jmacd
    jmacd committed Aug 20, 2021
    Copy the full SHA
    e201f52 View commit details
    Browse the repository at this point in the history

  5. comments

    @jmacd
    jmacd committed Aug 20, 2021
    Copy the full SHA
    fdbe7c3 View commit details
    Browse the repository at this point in the history

  6. Changelog

    @jmacd
    jmacd committed Aug 20, 2021
    Copy the full SHA
    cb9e431 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2021

  1. Merge branch 'main' into jmacd/move_descriptor

    @jmacd
    jmacd committed Aug 23, 2021
    Copy the full SHA
    8c17495 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Merge branch 'main' into jmacd/move_descriptor

    @jmacd
    jmacd committed Aug 31, 2021
    Copy the full SHA
    9db6a72 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. Merge remote-tracking branch 'origin/main' into jmacd/move_descriptor

    @jmacd
    jmacd committed Sep 2, 2021
    Copy the full SHA
    feca077 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'jmacd/move_descriptor' of github.com:jmacd/opentelemetr… 

    …y-go into jmacd/move_descriptor
    @jmacd
    jmacd committed Sep 2, 2021
    Copy the full SHA
    c51c940 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into jmacd/move_descriptor

    @jmacd
    jmacd committed Sep 2, 2021
    Copy the full SHA
    93615ae View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Merge branch 'main' into jmacd/move_descriptor

    @jmacd
    jmacd committed Sep 8, 2021
    Copy the full SHA
    aab6115 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'jmacd/move_descriptor' of github.com:jmacd/opentelemetr… 

    …y-go into jmacd/move_descriptor
    @jmacd
    jmacd committed Sep 8, 2021
    Copy the full SHA
    4ae9be2 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: alrex <alrex.boten@gmail.com>
    @jmacd @codeboten
    jmacd and codeboten committed Sep 8, 2021
    Copy the full SHA
    e591fa5 View commit details
    Browse the repository at this point in the history

  4. remove an interdependency

    @jmacd
    jmacd committed Sep 8, 2021
    Copy the full SHA
    65b8f3e View commit details
    Browse the repository at this point in the history

  5. fix build

    @jmacd
    jmacd committed Sep 8, 2021
    Copy the full SHA
    7871e03 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge branch 'main' into jmacd/move_descriptor

    @jmacd
    jmacd committed Sep 14, 2021
    Copy the full SHA
    794ed0a View commit details
    Browse the repository at this point in the history

  2. re-indent one

    @jmacd
    jmacd committed Sep 14, 2021
    Copy the full SHA
    7f71842 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'jmacd/move_descriptor' of github.com:jmacd/opentelemetr… 

    …y-go into jmacd/move_descriptor
    @jmacd
    jmacd committed Sep 14, 2021
    Copy the full SHA
    823c957 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @jmacd @MrAlias
    jmacd and MrAlias committed Sep 15, 2021
    Copy the full SHA
    c18e5e7 View commit details
    Browse the repository at this point in the history

  2. Lint&feedback

    @jmacd
    jmacd committed Sep 15, 2021
    Copy the full SHA
    89b1fd1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'jmacd/move_descriptor' of github.com:jmacd/opentelemetr… 

    …y-go into jmacd/move_descriptor
    @jmacd
    jmacd committed Sep 15, 2021
    Copy the full SHA
    7a3d9a3 View commit details
    Browse the repository at this point in the history

  4. update after rename

    @jmacd
    jmacd committed Sep 15, 2021
    Copy the full SHA
    5032f63 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Merge branch 'main' into jmacd/move_descriptor

    @jmacd
    jmacd committed Sep 16, 2021
    Copy the full SHA
    a00f5fb View commit details
    Browse the repository at this point in the history

  2. comment fix

    @jmacd
    jmacd committed Sep 16, 2021
    Copy the full SHA
    472b113 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. style fix for meter options

    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    52b6ca9 View commit details
    Browse the repository at this point in the history

  2. remove libraryReader, let Controller implement the reader API directly

    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    2780b45 View commit details
    Browse the repository at this point in the history

  3. rename 'impl' field to 'provider'

    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    3b7c3ca View commit details
    Browse the repository at this point in the history

  4. remove a type assertion

    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    23d0585 View commit details
    Browse the repository at this point in the history

  5. move metric/registry into internal; move registry.MeterProvider into … 

    …metric controller
    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    a927758 View commit details
    Browse the repository at this point in the history

  6. add test for controller registry function

    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    f1b51da View commit details
    Browse the repository at this point in the history

  7. CheckpointSet->Reader everywhere

    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    d09e2e2 View commit details
    Browse the repository at this point in the history

  8. lint

    @jmacd
    jmacd committed Sep 17, 2021
    Copy the full SHA
    6ad398d View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Merge branch 'main' of github.com:open-telemetry/opentelemetry-go int… 

    …o jmacd/move_descriptor
    @jmacd
    jmacd committed Sep 21, 2021
    Copy the full SHA
    9b990d2 View commit details
    Browse the repository at this point in the history

  2. remove two unnecessary accessor methods; Controller implements MeterP… 

    …rovider and InstrumentationLibraryReader directly, no need to get these
    @jmacd
    jmacd committed Sep 21, 2021
    Copy the full SHA
    989066b View commit details
    Browse the repository at this point in the history

  3. use a sync.Map

    @jmacd
    jmacd committed Sep 21, 2021
    Copy the full SHA
    ea7bc59 View commit details
    Browse the repository at this point in the history

  4. ensure the initOnce is always called; handle multiple errors

    @jmacd
    jmacd committed Sep 21, 2021
    Copy the full SHA
    3356eb5 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @jmacd @Aneurysm9
    jmacd and Aneurysm9 committed Sep 23, 2021
    Copy the full SHA
    b4636f3 View commit details
    Browse the repository at this point in the history

  2. cleanup locking in metrictest

    @jmacd
    jmacd committed Sep 23, 2021
    Copy the full SHA
    b418d3d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'jmacd/move_descriptor' of github.com:jmacd/opentelemetr… 

    …y-go into jmacd/move_descriptor
    @jmacd
    jmacd committed Sep 23, 2021
    Copy the full SHA
    21f7401 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Revert "ensure the initOnce is always called; handle multiple errors" 

    This reverts commit 3356eb5.
    @jmacd
    jmacd committed Sep 24, 2021
    Copy the full SHA
    265232b View commit details
    Browse the repository at this point in the history

  2. Revert "use a sync.Map" 

    This reverts commit ea7bc59.
    @jmacd
    jmacd committed Sep 24, 2021
    Copy the full SHA
    2e183e9 View commit details
    Browse the repository at this point in the history

  3. restore the TODO about sync.Map

    @jmacd
    jmacd committed Sep 24, 2021
    Copy the full SHA
    6e984a5 View commit details
    Browse the repository at this point in the history