Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 parsing errors in semconv.NetAttributesFromHTTPRequest #2285

Merged
merged 9 commits into from Oct 18, 2021
Merged

Fix IPv6 parsing errors in semconv.NetAttributesFromHTTPRequest #2285

merged 9 commits into from Oct 18, 2021

Commits on Oct 13, 2021

  1. Fix IPv6 handling errors in semconv.NetAttributesFromHTTPRequest 

    fixes open-telemetry#2283
    @evantorrie
    evantorrie committed Oct 13, 2021
    Copy the full SHA
    996504b View commit details
    Browse the repository at this point in the history

  2. Enter PR number in CHANGELOG

    @evantorrie
    evantorrie committed Oct 13, 2021
    Copy the full SHA
    e674a99 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary creation and then assignment 

    Standardize order of checks for IP, Name, Port
    @evantorrie
    evantorrie committed Oct 13, 2021
    Copy the full SHA
    d4017e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Assume happy path when parsing host and port 

    i.e. assume net.SplitHostPort(input) will succeed
    @evantorrie
    evantorrie committed Oct 14, 2021
    Copy the full SHA
    1335150 View commit details
    Browse the repository at this point in the history

  2. Get rid of uint64 for port

    @evantorrie
    evantorrie committed Oct 14, 2021
    Copy the full SHA
    1958448 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Merge branch 'main' into http_attribute_fix

    @MrAlias
    MrAlias committed Oct 18, 2021
    Copy the full SHA
    523c66d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into http_attribute_fix

    @MrAlias
    MrAlias committed Oct 18, 2021
    Copy the full SHA
    5b100f8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into http_attribute_fix

    @MrAlias
    MrAlias committed Oct 18, 2021
    Copy the full SHA
    4ee3142 View commit details
    Browse the repository at this point in the history

  4. Fix git merge of main by adding back strings import

    @MrAlias
    MrAlias committed Oct 18, 2021
    Copy the full SHA
    69b88ab View commit details
    Browse the repository at this point in the history