Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the grpc.ClientConn to handle connections for the otlptracegrpc client #2329

Merged
merged 37 commits into from Nov 25, 2021
Merged

Use the grpc.ClientConn to handle connections for the otlptracegrpc client #2329

merged 37 commits into from Nov 25, 2021

Commits on Nov 22, 2021

  1. POC using the grpc.ClientConn to handle connections

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    fabc9bf View commit details
    Browse the repository at this point in the history

  2. Update invalid client security test

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    d9dd484 View commit details
    Browse the repository at this point in the history

  3. Update client start test for a bad endpoint

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    df30aa7 View commit details
    Browse the repository at this point in the history

  4. Use any ClientConn a user provides

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    faa7981 View commit details
    Browse the repository at this point in the history

  5. Connect ReconnectionPeriod to gRPC conn retries

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    03ff8a7 View commit details
    Browse the repository at this point in the history

  6. Replace connection retry handling direct in otlptracegrpc

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    8e5494b View commit details
    Browse the repository at this point in the history

  7. Fix client comments

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    a6872c3 View commit details
    Browse the repository at this point in the history

  8. Fix comment for NewGRPCConfig

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    2c19be8 View commit details
    Browse the repository at this point in the history

  9. Replace reconnection test

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    d37ea99 View commit details
    Browse the repository at this point in the history

  10. Fix grammar

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    2629f11 View commit details
    Browse the repository at this point in the history

  11. Remove unrelated changes

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    2cccd27 View commit details
    Browse the repository at this point in the history

  12. Remove connection pkg

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    9637c81 View commit details
    Browse the repository at this point in the history

  13. Rename evaluate to retryable

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    071cc40 View commit details
    Browse the repository at this point in the history

  14. POC using the grpc.ClientConn to handle connections

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    2aebe6a View commit details
    Browse the repository at this point in the history

  15. Replace connection retry handling direct in otlptracegrpc

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    1cffc27 View commit details
    Browse the repository at this point in the history

  16. Add ClientConn use changes to changelog

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    25defaa View commit details
    Browse the repository at this point in the history

  17. Update otlptracegrpc options

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    6d06f64 View commit details
    Browse the repository at this point in the history

  18. Only close ClientConn that the Client create

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    5f30159 View commit details
    Browse the repository at this point in the history

  19. Remove listener wrapper from mock_collector_test 

    This is not needed now that no tests relies on the listener to wait for
a connection to be established before continuing.
    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    8c7cb66 View commit details
    Browse the repository at this point in the history

  20. Fix spelling error

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    bc0c507 View commit details
    Browse the repository at this point in the history

  21. Do not use deprecated options in the otel-collector example

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    0dfcac2 View commit details
    Browse the repository at this point in the history

  22. Add unit tests for retryable and throttleDelay funcs

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    2ce320f View commit details
    Browse the repository at this point in the history

  23. Add unit tests for context heredity

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    a50e7d6 View commit details
    Browse the repository at this point in the history

  24. Add test that exporter stop is linked to context cancel

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    c7b7a8c View commit details
    Browse the repository at this point in the history

  25. go mod tidy

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    2326ecb View commit details
    Browse the repository at this point in the history

  26. Update exporters/otlp/otlptrace/otlptracegrpc/client.go 

    Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
    @MrAlias @Aneurysm9
    MrAlias and Aneurysm9 committed Nov 22, 2021
    Copy the full SHA
    5c07c31 View commit details
    Browse the repository at this point in the history

  27. Fix go.mod from rebase

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    b3e151d View commit details
    Browse the repository at this point in the history

  28. Remove wrong comment about client stop closing gRPC conn

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    ab98555 View commit details
    Browse the repository at this point in the history

  29. Fix shutdown test cleanup 

    Do not check the second call to the client Stop. There is no guarantee
it will not error in normal operation.
    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    7067fe0 View commit details
    Browse the repository at this point in the history

  30. Make lint fixes

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    549f1f8 View commit details
    Browse the repository at this point in the history

  31. Fix flaky unit test 

    Use the internals of the client to explicit cancel the context returned
from exportContext. This gets around the bug where the select in Stop
may randomly choose the non-context Done case and avoid returning an
error (also failing to cancel the context).
    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    0952683 View commit details
    Browse the repository at this point in the history

  32. Remove deprecation 

    To configure the client/exporter with environment variables these
options are used. There is no way to fully remove these options without
removing support for configuration with environment variables. Leave
that decision and strategy determination to a separate PR.
    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    8c07b29 View commit details
    Browse the repository at this point in the history

  33. Merge branch 'main' into poc-grpc-clientconn

    @MrAlias
    MrAlias committed Nov 22, 2021
    Copy the full SHA
    e7f98e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Fix grammatical error in comment

    @MrAlias
    MrAlias committed Nov 23, 2021
    Copy the full SHA
    2b313ef View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into poc-grpc-clientconn

    @MrAlias
    MrAlias committed Nov 23, 2021
    Copy the full SHA
    702fdd7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into poc-grpc-clientconn

    @MrAlias
    MrAlias committed Nov 23, 2021
    Copy the full SHA
    460535c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into poc-grpc-clientconn

    @MrAlias
    MrAlias committed Nov 23, 2021
    Copy the full SHA
    5c9bcc3 View commit details
    Browse the repository at this point in the history