Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty queued spans when ForceFlush called #2335

Merged
merged 9 commits into from Nov 5, 2021
Merged

Empty queued spans when ForceFlush called #2335

merged 9 commits into from Nov 5, 2021

Commits on Oct 28, 2021

  1. Empty queued spans when ForceFlush called 

    Update the implementation of ForceFlush() to first ensure that all spans
which are queued are added to the batch before calling export spans.
Create a small ReadOnlySpan implementation which can be used as a marker
that ForceFlush has been invoked and used to notify when all spans are
ready to be exported.

Fixes #2080.
    @pkwarren
    pkwarren committed Oct 28, 2021
    Copy the full SHA
    b2dd3c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Add a changelog entry.

    @pkwarren
    pkwarren committed Oct 29, 2021
    Copy the full SHA
    0e621b8 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @pkwarren @MrAlias
    pkwarren and MrAlias committed Oct 29, 2021
    Copy the full SHA
    c7e4c51 View commit details
    Browse the repository at this point in the history

  3. Update sdk/trace/batch_span_processor.go 

    Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
    @pkwarren @MrAlias
    pkwarren and MrAlias committed Oct 29, 2021
    Copy the full SHA
    4eb4f2b View commit details
    Browse the repository at this point in the history

  4. Improve test case to verify multiple flushes.

    @pkwarren
    pkwarren committed Oct 29, 2021
    Copy the full SHA
    0180f37 View commit details
    Browse the repository at this point in the history

  5. Refactor code to use enqueue.

    @pkwarren
    pkwarren committed Oct 29, 2021
    Copy the full SHA
    cb23081 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2021

  1. Be more defensive on waiting for queue. 

    Update the handling of the force flush span so we only wait on the
channel if we were able to enqueue the span to the queue.
    @pkwarren
    pkwarren committed Oct 30, 2021
    Copy the full SHA
    bf24f4c View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Fix linter.

    @pkwarren
    pkwarren committed Nov 3, 2021
    Copy the full SHA
    c03a61a View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Merge branch 'main' into issue-2080

    @Aneurysm9
    Aneurysm9 committed Nov 4, 2021
    Copy the full SHA
    486120a View commit details
    Browse the repository at this point in the history