Update dependencies #2374

MrAlias · 2021-11-11T16:18:02Z

Bump github.com/golangci/golangci-lint from 1.42.1 to 1.43.0 in /internal/tools (supersedes and closes Bump github.com/golangci/golangci-lint from 1.42.1 to 1.43.0 in /internal/tools #2368)
Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlpmetric (supersedes and closes Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlpmetric #2367)
Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlpmetric/otlpmetrichttp (supersedes and closes Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlpmetric/otlpmetrichttp #2366)
Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlpmetric (supersedes and closes Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlpmetric #2365)
Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlptrace (supersedes and closes Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlptrace #2364)
Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlpmetric/otlpmetricgrpc (supersedes and closes Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlpmetric/otlpmetricgrpc #2363)
Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlptrace (supersedes and closes Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlptrace #2362)
Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlptrace/otlptracehttp (supersedes and closes Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlptrace/otlptracehttp #2361)
Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlptrace/otlptracegrpc (supersedes and closes Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /exporters/otlp/otlptrace/otlptracegrpc #2360)
Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlpmetric/otlpmetricgrpc (supersedes and closes Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlpmetric/otlpmetricgrpc #2359)
Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlptrace/otlptracegrpc (supersedes and closes Bump go.opentelemetry.io/proto/otlp from 0.9.0 to 0.10.0 in /exporters/otlp/otlptrace/otlptracegrpc #2358)
Bump github.com/benbjohnson/clock from 1.1.0 to 1.2.0 in /sdk/metric (supersedes and closes Bump github.com/benbjohnson/clock from 1.1.0 to 1.2.0 in /sdk/metric #2357)
Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /example/otel-collector (supersedes and closes Bump google.golang.org/grpc from 1.41.0 to 1.42.0 in /example/otel-collector #2356)

Bumps [github.com/benbjohnson/clock](https://github.com/benbjohnson/clock) from 1.1.0 to 1.2.0. - [Release notes](https://github.com/benbjohnson/clock/releases) - [Commits](benbjohnson/clock@v1.1.0...v1.2.0) --- updated-dependencies: - dependency-name: github.com/benbjohnson/clock dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/proto/otlp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.41.0...v1.42.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/proto/otlp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.41.0...v1.42.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/proto/otlp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.41.0...v1.42.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go) from 0.9.0 to 0.10.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v0.9.0...v0.10.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/proto/otlp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.41.0...v1.42.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.42.1 to 1.43.0. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.42.1...v1.43.0) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.41.0...v1.42.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

…/tools/github.com/golangci/golangci-lint-1.43.0' into update-deps

…s/otlp/otlpmetric/google.golang.org/grpc-1.42.0' into update-deps

…s/otlp/otlpmetric/otlpmetrichttp/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

…s/otlp/otlpmetric/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

…s/otlp/otlptrace/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

…s/otlp/otlpmetric/otlpmetricgrpc/google.golang.org/grpc-1.42.0' into update-deps

…s/otlp/otlptrace/google.golang.org/grpc-1.42.0' into update-deps

…s/otlp/otlptrace/otlptracehttp/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

…s/otlp/otlptrace/otlptracegrpc/google.golang.org/grpc-1.42.0' into update-deps

…s/otlp/otlpmetric/otlpmetricgrpc/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

…s/otlp/otlptrace/otlptracegrpc/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

…ic/github.com/benbjohnson/clock-1.2.0' into update-deps

Aneurysm9 · 2021-11-11T16:50:26Z

Looks like golangci-lint requires Go 1.16+

We should discuss this at the SIG meeting today. I think we can't maintain compatibility with older versions indefinitely and I expect to see many projects require 1.17 once 1.16 isn't supported upstream due to the improvements in module handling.

MrAlias · 2021-11-11T16:51:39Z

Looks like golangci-lint requires Go 1.16+

We should discuss this at the SIG meeting today. I think we can't maintain compatibility with older versions indefinitely and I expect to see many projects require 1.17 once 1.16 isn't supported upstream due to the improvements in module handling.

Agreed.

MrAlias · 2021-11-11T17:10:01Z

/easycla

MrAlias · 2021-11-11T17:23:48Z

/easycla

MrAlias · 2021-11-11T17:50:55Z

/easycla

MadVikingGod · 2021-11-11T18:49:15Z

I noted that lint did require 1.16 that, but that is only a part of our "build" process. Because the API or SDK don't import golangci-lint, go 1.15 should still be able to use them as a library. We just have to bump our test "build" platforms.

MrAlias · 2021-11-11T19:10:05Z

I noted that lint did require 1.16 that, but that is only a part of our "build" process. Because the API or SDK don't import golangci-lint, go 1.15 should still be able to use them as a library. We just have to bump our test "build" platforms.

Gotcha, I'll add that here. Not going anywhere real fast given EasyCLA looks stuck.

Our lint and race testers use this version of Go and we still explicitly check version 1.15 with our compatibility tests. This will allow us to update golangci-lint which requires Go 1.16.

…modules/internal/tools/github.com/golangci/golangci-lint-1.43.0' into update-deps"" This reverts commit 9d19c7d.

codecov · 2021-11-11T19:16:01Z

Codecov Report

Merging #2374 (912d727) into main (3b9e067) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #2374     +/-   ##
=======================================
- Coverage   73.8%   73.7%   -0.1%     
=======================================
  Files        175     175             
  Lines      12436   12436             
=======================================
- Hits        9182    9176      -6     
- Misses      3017    3023      +6     
  Partials     237     237

Impacted Files	Coverage Δ
sdk/trace/batch_span_processor.go	`83.2% <0.0%> (-2.1%)`	⬇️
exporters/jaeger/jaeger.go	`93.4% <0.0%> (-0.9%)`	⬇️

MrAlias · 2021-11-11T19:27:50Z

/easycla

MrAlias · 2021-11-11T20:23:05Z

/easycla

MrAlias · 2021-11-11T21:35:39Z

/easycla

Aneurysm9 · 2021-11-11T22:23:06Z

/easycla ಠ_ಠ

MrAlias · 2021-11-11T22:33:51Z

I really don't get how it worked for #2376 but not this ...

Aneurysm9 · 2021-11-11T22:57:59Z

I wonder if it is because Dependabot is still the author of commits on the branch. I pulled this into #2377 and it is doing the same thing there.

MrAlias · 2021-11-11T23:13:56Z

I wonder if it is because Dependabot is still the author of commits on the branch. I pulled this into #2377 and it is doing the same thing there.

Interesting, I'll try collapsing this and see if that works.

MrAlias · 2021-11-11T23:31:30Z

It looks like I got a working version in #2378. It might be the merges of main from the GitHub console that are causing the problem. Not 100%, but in the linked PR when I did that it failed to run the EasyCI check. Likely relevant for #2373.

dependabot bot and others added 26 commits November 7, 2021 00:08

Merge remote-tracking branch 'upstream/dependabot/go_modules/internal…

a81ef6c

…/tools/github.com/golangci/golangci-lint-1.43.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

442b0a9

…s/otlp/otlpmetric/google.golang.org/grpc-1.42.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

f26a228

…s/otlp/otlpmetric/otlpmetrichttp/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

db78453

…s/otlp/otlpmetric/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

de000cb

…s/otlp/otlptrace/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

a4a81db

…s/otlp/otlpmetric/otlpmetricgrpc/google.golang.org/grpc-1.42.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

4067b0e

…s/otlp/otlptrace/google.golang.org/grpc-1.42.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

0723485

…s/otlp/otlptrace/otlptracehttp/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

81d2961

…s/otlp/otlptrace/otlptracegrpc/google.golang.org/grpc-1.42.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

3ceaadc

…s/otlp/otlpmetric/otlpmetricgrpc/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/exporter…

2c244e1

…s/otlp/otlptrace/otlptracegrpc/go.opentelemetry.io/proto/otlp-0.10.0' into update-deps

Merge remote-tracking branch 'upstream/dependabot/go_modules/sdk/metr…

44eb836

…ic/github.com/benbjohnson/clock-1.2.0' into update-deps

go mod tidy

cf050b1

MrAlias requested review from Aneurysm9, dashpole, evantorrie and jmacd as code owners November 11, 2021 16:18

Merge branch 'main' into update-deps

125a33b

Aneurysm9 approved these changes Nov 11, 2021

View reviewed changes

MrAlias closed this Nov 11, 2021

MrAlias reopened this Nov 11, 2021

MrAlias added 2 commits November 11, 2021 11:10

Update default Go version the test runners use.

c7ee600

Our lint and race testers use this version of Go and we still explicitly check version 1.15 with our compatibility tests. This will allow us to update golangci-lint which requires Go 1.16.

Revert "Revert "Merge remote-tracking branch 'upstream/dependabot/go_…

9577e24

…modules/internal/tools/github.com/golangci/golangci-lint-1.43.0' into update-deps"" This reverts commit 9d19c7d.

evantorrie approved these changes Nov 11, 2021

View reviewed changes

MrAlias closed this Nov 11, 2021

MrAlias reopened this Nov 11, 2021

Merge branch 'main' into update-deps

912d727

MrAlias mentioned this pull request Nov 11, 2021

Upgrade packages #2378

Merged

MrAlias closed this Nov 11, 2021

MrAlias deleted the update-deps branch November 11, 2021 23:34

MrAlias mentioned this pull request Nov 11, 2021

Disables collectorConnectionDiesThenReconnects because it is flaky #2373

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies #2374

Update dependencies #2374

MrAlias commented Nov 11, 2021 •

edited

Aneurysm9 commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MadVikingGod commented Nov 11, 2021

MrAlias commented Nov 11, 2021

codecov bot commented Nov 11, 2021 •

edited

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

Aneurysm9 commented Nov 11, 2021

MrAlias commented Nov 11, 2021

Aneurysm9 commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

Update dependencies #2374

Update dependencies #2374

Conversation

MrAlias commented Nov 11, 2021 • edited

Aneurysm9 commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MadVikingGod commented Nov 11, 2021

MrAlias commented Nov 11, 2021

codecov bot commented Nov 11, 2021 • edited

Codecov Report

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

Aneurysm9 commented Nov 11, 2021

MrAlias commented Nov 11, 2021

Aneurysm9 commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021

MrAlias commented Nov 11, 2021 •

edited

codecov bot commented Nov 11, 2021 •

edited