Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk/export/metric module, embed into the sdk/metric #2382

Merged
merged 1 commit into from Dec 13, 2021

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Nov 12, 2021

Updates #2273.

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #2382 (3f91b9e) into main (aedef05) will increase coverage by 0.3%.
The diff coverage is 91.0%.

❗ Current head 3f91b9e differs from pull request most recent head 03f3482. Consider uploading reports for the commit 03f3482 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2382     +/-   ##
=======================================
+ Coverage   76.0%   76.3%   +0.3%     
=======================================
  Files        173     173             
  Lines      12010   12010             
=======================================
+ Hits        9132    9170     +38     
+ Misses      2633    2595     -38     
  Partials     245     245             
Impacted Files Coverage Δ
bridge/opencensus/aggregation.go 95.7% <ø> (ø)
bridge/opencensus/exporter.go 100.0% <ø> (ø)
...otlp/otlpmetric/internal/metrictransform/metric.go 78.1% <ø> (ø)
...rs/otlp/otlpmetric/internal/otlpmetrictest/data.go 0.0% <0.0%> (ø)
...tlp/otlpmetric/internal/otlpmetrictest/otlptest.go 0.0% <ø> (ø)
exporters/otlp/otlpmetric/options.go 100.0% <ø> (ø)
exporters/prometheus/prometheus.go 65.2% <ø> (ø)
exporters/stdout/stdoutmetric/exporter.go 62.5% <ø> (ø)
sdk/metric/aggregator/aggregator.go 100.0% <ø> (ø)
sdk/metric/aggregator/aggregatortest/test.go 81.0% <ø> (ø)
... and 20 more

@bogdandrutu bogdandrutu force-pushed the rmexportmetric branch 3 times, most recently from 0ed195c to ae92308 Compare November 12, 2021 23:34
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please deprecate the old package instead of removing so users know what to use instead. We can remove in the following release to the release that includes this deprecation.

@jmacd
Copy link
Contributor

jmacd commented Nov 15, 2021

I'd like to merge #2348 #2350 and #2352 before this sort of improvement. 😁

@jmacd
Copy link
Contributor

jmacd commented Nov 15, 2021

See #2273.

@bogdandrutu bogdandrutu force-pushed the rmexportmetric branch 2 times, most recently from 2d4598b to 9b2404b Compare November 15, 2021 18:40
@MrAlias
Copy link
Contributor

MrAlias commented Dec 2, 2021

@bogdandrutu all the dependent PRs have merged. Are you able to update this PR to deprecate the package?

@bogdandrutu bogdandrutu force-pushed the rmexportmetric branch 3 times, most recently from 07e40b0 to 7fec1ff Compare December 13, 2021 18:59
@bogdandrutu
Copy link
Member Author

@MrAlias deprecation is done.

@bogdandrutu
Copy link
Member Author

@jmacd this is an intermediate PR, will do the last move inside the new package after. I have enough time until the next release. Is that ok with you @MrAlias ?

sdk/export/metric/metric.go Outdated Show resolved Hide resolved
sdk/export/metric/go.mod Show resolved Hide resolved
@MrAlias
Copy link
Contributor

MrAlias commented Dec 13, 2021

@jmacd this is an intermediate PR, will do the last move inside the new package after. I have enough time until the next release. Is that ok with you @MrAlias ?

SGTM

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@MrAlias MrAlias merged commit 6cafa6a into open-telemetry:main Dec 13, 2021
@bogdandrutu bogdandrutu deleted the rmexportmetric branch December 13, 2021 20:18
@MrAlias MrAlias mentioned this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants