Fixes broken sdk/metric benchmarks #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadVikingGod
added
the
Skip Changelog
MadVikingGod
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2459 +/- ##
=======================================
- Coverage 76.3% 76.2% -0.1%
=======================================
Files 173 173
Lines 12010 12010
=======================================
- Hits 9165 9163 -2
- Misses 2600 2602 +2
Partials 245 245
|
XSAM
approved these changes
Dec 16, 2021
MrAlias
approved these changes
Dec 16, 2021
bogdandrutu
reviewed
Dec 16, 2021
| ctx := context.Background() | ||
| fix := newFixture(b) | ||
| labs := makeLabels(1) | ||
| mea := fix.meterMust().NewInt64Histogram(name) | ||
| mea := fix.meterMust().NewInt64Histogram("int64.histogram") |
There was a problem hiding this comment.
Does the name suffix hardcode something? Not clear how changing the name fixes this.
There was a problem hiding this comment.
Aneurysm9
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sdk/metric benchmarks panic trying to create an exact aggregator. These were removed in #2348. This fix retains benchmarks around the creation of histograms, but moves them into a histogram creation.
You can see the panic: https://gist.github.com/MadVikingGod/f7f1eb41aa83be4729481f7c10415be5