Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate members once, in NewMember #2522

Merged
merged 9 commits into from Feb 4, 2022
Merged

Validate members once, in NewMember #2522

merged 9 commits into from Feb 4, 2022

Commits on Feb 4, 2022

  1. use NewMember, or specify if the member is not validated when creatin… 

    …g new ones
    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    521e305 View commit details
    Browse the repository at this point in the history

  2. expect members to already be validated when creating a new package

    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    b5e1d96 View commit details
    Browse the repository at this point in the history

  3. add changelog entry

    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    ef06555 View commit details
    Browse the repository at this point in the history

  4. add an isEmpty field to member and property for quick validation

    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    51fb015 View commit details
    Browse the repository at this point in the history

  5. rename isEmpty to hasData 

    So by default, an empty struct really is marked as having no data
    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    3bcf764 View commit details
    Browse the repository at this point in the history

  6. Update baggage/baggage_test.go 

    Co-authored-by: Aaron Clawson <Aaron.Clawson@gmail.com>
    @MadVikingGod @dmathieu
    2 people authored and dmathieu committed Feb 4, 2022
    Copy the full SHA
    a4509ec View commit details
    Browse the repository at this point in the history

  7. don't validate the member in parseMember, we alredy ran that validation 

    We also don't want to use NewMember, as that runs the property
validation again, making the benchmark quite slower
    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    01c595b View commit details
    Browse the repository at this point in the history

  8. move changelog entry to the fixed section

    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    e4c535f View commit details
    Browse the repository at this point in the history

  9. provide the member/property data when returning an invalid error

    @dmathieu
    dmathieu committed Feb 4, 2022
    Copy the full SHA
    b3d6bb7 View commit details
    Browse the repository at this point in the history