Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Epic 2/4] Move packages to sdk #2585

Closed

Conversation

MadVikingGod
Copy link
Contributor

This is a series of patches to update the metrics API. Here is the diff against the previous step

  1. New API [API Epic 1/4] Metric api prototype #2557
  2. Move retained packages under SDK (This patch)
  3. Create a wrapper for current SDK to be used as new API #????
  4. Fix reaming tests and examples. #????

This patch set moves metrics/metrictest, metrics/number, metric/internal/registry, metric/sdkapi to sdk/metric/*

The Moved compoents are:
- metric/metrictest
- metric/number
- metric/internal/registry
- metric/sdkapi
Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 😁

@MadVikingGod MadVikingGod deleted the metrics-api/2-move-sdkapi branch February 21, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants