New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API EPIC 4/4] Fix tests and examples #2587
Merged
MadVikingGod
merged 21 commits into
open-telemetry:main
from
MadVikingGod:metrics-api/4-tests
Mar 2, 2022
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
281a662
Empty All of the metrics dir
MadVikingGod 7bd4f00
Add instrument api with documentation
MadVikingGod 754d83c
Add a NoOp implementation.
MadVikingGod b2dab0c
Updated to the new config standard
MadVikingGod a92285c
fix grammer.
MadVikingGod 4dab081
Merge remote-tracking branch 'upstream/main' into metric-api
MadVikingGod ad95b08
Address PR comments
MadVikingGod 16a42f5
Merge branch 'main' into metric-api
MadVikingGod a7a02c3
This changes moves components to sdk/metrics
MadVikingGod 45e799a
The SDK changes necessary to satasify the new api
MadVikingGod 2e75522
This fixes the remaing tests.
MadVikingGod 09f0446
Update changelog
MadVikingGod 20d9758
fix pull_test
MadVikingGod 52e921c
Merge remote-tracking branch 'upstream/main' into metrics-api/4-tests
MadVikingGod b6c7e7c
Fixes for PR comments.
MadVikingGod 18b9fc4
refactor the noop meter and instruments into one package.
MadVikingGod 32b6eba
Fix linting
MadVikingGod d8ebfab
Fix mod tidy.
MadVikingGod 0dd1d52
Renamed pkg.Instruments to pkg.InstrumentProvider
MadVikingGod 775fb28
Merge remote-tracking branch 'upstream/main' into metrics-api/4-tests
MadVikingGod 4792a7c
Merge remote-tracking branch 'upstream/main' into metrics-api/4-tests
MadVikingGod File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do really miss Must() for instrument initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the Must() forms tend to make the code read better, but they really don't make sense in this world. Both because this would either mean extra API surface, but also because our meter <-> instrument relation is different from both Prometheus and opencensus. Both had a static implementation of our meter, and it could create new instruments at init. That model doesn't work very well when you have to initialize your meter before you register instruments.