Remove the otlp trace exporter limit of SpanEvents when exporting

CHANGELOG.md

@@ -8,6 +8,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 ## [Unreleased]
 
+### Fixed
+
+- Remove the limit of SpanEvents when exporting. (#2616)
+
 ## [1.4.0] - 2022-02-11
 
 ### Added

exporters/otlp/otlptrace/internal/tracetransform/span.go

@@ -23,10 +23,6 @@ import (
 	tracepb "go.opentelemetry.io/proto/otlp/trace/v1"
 )
 
-const (
-	maxEventsPerSpan = 128
-)
-
 // Spans transforms a slice of OpenTelemetry spans into a slice of OTLP
 // ResourceSpans.
 func Spans(sdl []tracesdk.ReadOnlySpan) []*tracepb.ResourceSpans {
@@ -176,19 +172,9 @@ func spanEvents(es []tracesdk.Event) []*tracepb.Span_Event {
 		return nil
 	}
 
-	evCount := len(es)
-	if evCount > maxEventsPerSpan {
-		evCount = maxEventsPerSpan
-	}
-	events := make([]*tracepb.Span_Event, 0, evCount)
-	nEvents := 0
-
+	events := make([]*tracepb.Span_Event, 0, len(es))
 	// Transform message events
 	for _, e := range es {
-		if nEvents >= maxEventsPerSpan {
-			break
-		}
-		nEvents++
 		events = append(events,
 			&tracepb.Span_Event{
 				Name:         e.Name,
@@ -198,7 +184,6 @@ func spanEvents(es []tracesdk.Event) []*tracepb.Span_Event {
 			},
 		)
 	}
-
 	return events
 }
 

exporters/otlp/otlptrace/internal/tracetransform/span_test.go

@@ -15,7 +15,6 @@
 package tracetransform
 
 import (
-	"strconv"
 	"testing"
 	"time"
 
@@ -101,18 +100,6 @@ func TestSpanEvent(t *testing.T) {
 	assert.Equal(t, &tracepb.Span_Event{Name: "test 2", Attributes: KeyValues(attrs), TimeUnixNano: eventTimestamp}, got[1])
 }
 
-func TestExcessiveSpanEvents(t *testing.T) {
-	e := make([]tracesdk.Event, maxEventsPerSpan+1)
-	for i := 0; i < maxEventsPerSpan+1; i++ {
-		e[i] = tracesdk.Event{Name: strconv.Itoa(i)}
-	}
-	assert.Len(t, e, maxEventsPerSpan+1)
-	got := spanEvents(e)
-	assert.Len(t, got, maxEventsPerSpan)
-	// Ensure the drop order.
-	assert.Equal(t, strconv.Itoa(maxEventsPerSpan-1), got[len(got)-1].Name)
-}
-
 func TestNilLinks(t *testing.T) {
 	assert.Nil(t, links(nil))
 }