refactor(sdk/metrics): add histogramAggs method #2648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1046102779
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
paivagustavo,
MadVikingGod,
pellared and
hanyuancheung
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2648 +/- ##
=======================================
- Coverage 75.6% 75.6% -0.1%
=======================================
Files 172 172
Lines 11551 11548 -3
=======================================
- Hits 8736 8733 -3
Misses 2605 2605
Partials 210 210
|
hanyuancheung
added
the
Skip Changelog
dmathieu
reviewed
Mar 3, 2022
| func (selectorInexpensive) AggregatorFor(descriptor *sdkapi.Descriptor, aggPtrs ...*aggregator.Aggregator) { | ||
| switch descriptor.InstrumentKind() { | ||
| case sdkapi.GaugeObserverInstrumentKind: | ||
| lastValueAggs(aggPtrs) | ||
| case sdkapi.HistogramInstrumentKind: |
There was a problem hiding this comment.
Just commenting here because it took me a few seconds to understand why this code was removed.
The sumAggs method does the same thing, so there's no need for the repetition.
|
With the new metrics API from #2587 landed, this entire SDK is on the chopping block and slated for replacement. I'm not sure it's worth tinkering at the edges of it at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.