Fix Monotonicity of Histogram aggregated by Sum #3101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
|
This is a tiny fix in the legacy metrics SDK. I'm not sure we're accepting those today, but if possible, I'd like this fixed. |
Codecov Report
@@ Coverage Diff @@
## main #3101 +/- ##
=====================================
Coverage 76.2% 76.2%
=====================================
Files 179 179
Lines 11942 11942
=====================================
+ Hits 9108 9110 +2
+ Misses 2594 2592 -2
Partials 240 240
|
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #2423 removed the MinMaxSumCount aggregation, histogram instruments with the "inexpensive" behavior began emitting Sum data points. Unfortunately, these Sum data points have been marked as non-monotonic, which is not a correct default.