Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP metric export errors use a consistent error message prefix #3515

Closed
wants to merge 2 commits into from

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Dec 5, 2022

When a user configures both a tracing SDK and metrics SDK the, existing error-handling and logging mechanism do not indicate whether it is a tracing or a metrics failure. For SDKs and vendors that route metrics and traces to different services, it is important to indicate which of the two paths is experiencing problems.

Part of #3513.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #3515 (73bcf01) into main (bc5cf7e) will decrease coverage by 0.0%.
The diff coverage is 90.9%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3515     +/-   ##
=======================================
- Coverage   78.1%   78.1%   -0.1%     
=======================================
  Files        165     165             
  Lines      11809   11812      +3     
=======================================
+ Hits        9226    9228      +2     
- Misses      2387    2388      +1     
  Partials     196     196             
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 76.6% <0.0%> (ø)
exporters/otlp/otlpmetric/internal/exporter.go 70.6% <100.0%> (+3.4%) ⬆️
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.8%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

@MrAlias
Copy link
Contributor

MrAlias commented Dec 8, 2022

Please fix the lint issues and add a changelog entry.

@jmacd
Copy link
Contributor Author

jmacd commented Dec 16, 2022

Will reopen this PR following the discussion in #3516.

Apologies for not passing lint before sending the PRs. I see that the lint tools are working again (what with all the churn related to generics)!

@jmacd jmacd closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants