Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Illustrate problem with baggage values #3689

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 7, 2023

Resolves #3685

While this technically resolves the ticket, I think this is the wrong change and instead #3226 should be reverted.

See: #3685 (comment)

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #3689 (3e1e440) into main (f5a1497) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3689   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files        171     171           
  Lines      12673   12674    +1     
=====================================
+ Hits       10103   10104    +1     
  Misses      2357    2357           
  Partials     213     213           
Impacted Files Coverage Δ
baggage/baggage.go 97.4% <100.0%> (+<0.1%) ⬆️
bridge/opentracing/bridge.go 63.4% <100.0%> (ø)
sdk/trace/batch_span_processor.go 81.1% <0.0%> (-0.9%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baggage API is not working, entangled with W3C Propagator
2 participants