Added methods for SpanID and TraceID on bridgeSpanContext

CHANGELOG.md

@@ -12,6 +12,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
 
 - The `go.opentelemetry.io/otel/metric/embedded` package. (#3916)
 - The `Version` function to `go.opentelemetry.io/otel/sdk` to return the SDK version. (#3949)
+- Methods `bridgeSpanContext.TraceID` and `bridgeSpanContext.SpanID` to `go.opentelemetry.io/otel/bridget/opentracing` to expose traceID and spanID for a span. (#3966)
 
 ### Changed
 

bridge/opentracing/README.md

@@ -57,3 +57,33 @@ if s, ok := sc.(samplable); ok && s.IsSampled() {
 	// Do something with sc knowing it is sampled.
 }
 ```
+
+### `SpanContext.TraceID`
+
+Return the underlying OpenTelemetry `Span.TraceID` value by converting a `bridgeSpanContext`.
+
+```go
+type traceId interface {
+	TraceID() bool
+}
+
+var sc opentracing.SpanContext = ...
+if s, ok := sc.(traceId); ok {
+	// Use TraceID by s.TraceID()
+}
+```
+
+### `SpanContext.SpanID`
+
+Return the underlying OpenTelemetry `Span.SpanID` value by converting a `bridgeSpanContext`.
+
+```go
+type spanId interface {
+	SpanID() bool
+}
+
+var sc opentracing.SpanContext = ...
+if s, ok := sc.(spanId); ok {
+	// Use SpanID by s.SpanID()
+}
+```

bridge/opentracing/bridge.go

@@ -76,6 +76,16 @@ func (c *bridgeSpanContext) IsSampled() bool {
 	return c.otelSpanContext.IsSampled()
 }
 
+// TraceID returns TraceID of underlying span
+func (c *bridgeSpanContext) TraceID() trace.TraceID {
+	return c.otelSpanContext.TraceID()
+}
+
+// SpanID returns SpanID of underlying span
+func (c *bridgeSpanContext) SpanID() trace.SpanID {
+	return c.otelSpanContext.SpanID()
+}
+
 func (c *bridgeSpanContext) setBaggageItem(restrictedKey, value string) {
 	crk := http.CanonicalHeaderKey(restrictedKey)
 	m, err := baggage.NewMember(crk, value)

bridge/opentracing/bridge_test.go

@@ -261,6 +261,14 @@ type samplable interface {
 	IsSampled() bool
 }
 
+type traceId interface {
+	TraceID() trace.TraceID
+}
+
+type spanId interface {
+	SpanID() trace.SpanID
+}
+
 func TestBridgeTracer_ExtractAndInject(t *testing.T) {
 	bridge := NewBridgeTracer()
 	bridge.SetTextMapPropagator(new(testTextMapPropagator))
@@ -546,3 +554,38 @@ func TestBridge_SpanContext_IsSampled(t *testing.T) {
 		})
 	}
 }
+
+func TestBridge_SpanContext_TraceID_SpanID(t *testing.T) {
+	bridge := NewBridgeTracer()
+	bridge.SetTextMapPropagator(new(testTextMapPropagator))
+
+	tmc := newTextCarrier()
+
+	testCases := []struct {
+		name    string
+		traceID trace.TraceID
+		spanID  trace.SpanID
+	}{
+		{
+			name:    "support for getting spanID and traceID",
+			traceID: [16]byte{byte(1)},
+			spanID:  [8]byte{byte(2)},
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			err := bridge.Inject(newBridgeSpanContext(trace.NewSpanContext(trace.SpanContextConfig{
+				TraceID: tc.traceID,
+				SpanID:  tc.spanID,
+			}), nil), ot.TextMap, tmc)
+			assert.NoError(t, err)
+
+			spanContext, err := bridge.Extract(ot.TextMap, tmc)
+			assert.NoError(t, err)
+
+			assert.Equal(t, spanID.String(), spanContext.(spanId).SpanID().String())
+			assert.Equal(t, traceID.String(), spanContext.(traceId).TraceID().String())
+		})
+	}
+}