[OpenTracing bridge] Support setting span kind tag after the creation of span #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenX1993
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
ChenX1993
force-pushed
the
dev/bridge-span-kind
branch
from
384910f
to
202cbe9
Compare
ChenX1993
changed the title
MrAlias
reviewed
Apr 13, 2023
ChenX1993
force-pushed
the
dev/bridge-span-kind
branch
from
202cbe9
to
b8e066b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3997 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 175 175
Lines 13058 12987 -71
=====================================
- Hits 10738 10681 -57
+ Misses 2099 2084 -15
- Partials 221 222 +1
|
ChenX1993
force-pushed
the
dev/bridge-span-kind
branch
from
b8e066b
to
27fe4c7
Compare
… of a span Signed-off-by: Chen Xu <chen.x@uber.com>
ChenX1993
force-pushed
the
dev/bridge-span-kind
branch
from
27fe4c7
to
ad34f57
Compare
WillSewell
reviewed
Feb 28, 2024
| // only add span kind tag when otel span kind is unset or bridge default (internal) | ||
| if span, ok := s.otelSpan.(readSpanKindSpan); ok { | ||
| if span.SpanKind() == trace.SpanKindUnspecified || span.SpanKind() == trace.SpanKindInternal { | ||
| s.otelSpan.SetAttributes(otTagToOTelAttr(key, value)) |
There was a problem hiding this comment.
This will cause the span.kind to be duplicated at the exporter level. This will set it in the attributes, but the recordingSpan.spanKind will also be set to the default internal - both of these seem to get sent via the exporter. I've tested this with go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc sending to Jaeger collector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3953
A few middleware frameworks (e.g https://github.com/yarpc/yarpc-go/blob/600cb49cc6331d8d15f65c058615a7649447efa7/api/transport/propagation.go#L67) that our company is using still set the OT span kind tag after a span is created.
Missing the span kind tags will impact a few functionalities in Jaeger (one of the OpenTracing implementations) that reply on the span kind tags.
Setting span kind tag in the bridge after a span is created cannot really set the SpanKind of OTel span, but adds the attribute instead which still helps in our case a lot.