Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenTracing Bridge] Support traceflags-only propagation without parent span #3998

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ChenX1993
Copy link
Contributor

@ChenX1993 ChenX1993 commented Apr 14, 2023

Resolves #3952

In order to support force sampling by some signal from the inbound request without a parent span, e.g jaeger-debug-id

@pellared
Copy link
Member

pellared commented Apr 14, 2023

Resolves #3966

Can you please mention the appropriate issue? 😉

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #3998 (a6bbc31) into main (eb2b89f) will decrease coverage by 0.1%.
The diff coverage is 16.6%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3998     +/-   ##
=======================================
- Coverage   82.1%   82.0%   -0.1%     
=======================================
  Files        175     175             
  Lines      12977   12988     +11     
=======================================
+ Hits       10655   10657      +2     
- Misses      2102    2110      +8     
- Partials     220     221      +1     
Impacted Files Coverage Δ
bridge/opentracing/bridge.go 63.9% <0.0%> (ø)
bridge/opentracing/internal/mock.go 63.9% <18.1%> (-3.2%) ⬇️

@ChenX1993
Copy link
Contributor Author

Resolves #3966

Can you please mention the appropriate issue? 😉

Thanks! Corrected.

@ChenX1993 ChenX1993 closed this Apr 14, 2023
@ChenX1993 ChenX1993 reopened this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants