sdk/metric: Add unit tests for Shutdown WithTimeout #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
dmathieu
approved these changes
Jul 28, 2023
dashpole
reviewed
Jul 28, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4379 +/- ##
=====================================
Coverage 83.4% 83.4%
=====================================
Files 184 184
Lines 14380 14380
=====================================
+ Hits 11997 11999 +2
+ Misses 2155 2153 -2
Partials 228 228 |
pellared
changed the title
CharlieTLe
reviewed
Aug 1, 2023
MrAlias
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT after #4377 is merged:
Add tests which are are almost copies of existing tests.