Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdk/resource: Fix data race with emptyAttributes #4409

Merged
merged 14 commits into from
Aug 7, 2023
Merged

sdk/resource: Fix data race with emptyAttributes #4409

merged 14 commits into from
Aug 7, 2023

Commits on Aug 4, 2023

  1. Fix ASAN bug with emptyAttributes. 

    If mutliple instantiations of a Resources struct are happening
in parallel, they can end up modifying the same underlying resource.
    @jaredjenkins
    jaredjenkins committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    eb02f96 View commit details
    Browse the repository at this point in the history

  2. Capture literal

    @jaredjenkins
    jaredjenkins committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    8c2aa29 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. add test

    @jaredjenkins
    jaredjenkins committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    5371689 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into jared/fix-race

    @jaredjenkins
    jaredjenkins committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    1d46dee View commit details
    Browse the repository at this point in the history

  3. remove unwanted change

    @jaredjenkins
    jaredjenkins committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    ed488f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Update sdk/resource/resource_test.go 

    Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @jaredjenkins @pellared
    jaredjenkins and pellared committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d720ac6 View commit details
    Browse the repository at this point in the history

  2. Update sdk/resource/resource_test.go 

    Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @jaredjenkins @pellared
    jaredjenkins and pellared committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    485442c View commit details
    Browse the repository at this point in the history

  3. Update sdk/resource/resource_test.go 

    Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @jaredjenkins @pellared
    jaredjenkins and pellared committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b07aabf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into jared/fix-race

    @jaredjenkins
    jaredjenkins committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    16c4d18 View commit details
    Browse the repository at this point in the history

  5. Update sdk/resource/resource_test.go 

    Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @jaredjenkins @pellared
    jaredjenkins and pellared committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c217540 View commit details
    Browse the repository at this point in the history

  6. Add changelog.

    @jaredjenkins
    jaredjenkins committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    a220c4b View commit details
    Browse the repository at this point in the history

  7. Update CHANGELOG.md 

    Co-authored-by: Robert Pająk <pellared@hotmail.com>
    @jaredjenkins @pellared
    jaredjenkins and pellared committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    89fcad9 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into jared/fix-race

    @MrAlias
    MrAlias committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    95eb62b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into jared/fix-race

    @MrAlias
    MrAlias committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    d111810 View commit details
    Browse the repository at this point in the history