Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoC] Use Set hash in Distinct #5028

Closed
wants to merge 14 commits into from

Merge branch 'main' into set-hash

7366740
Select commit
Failed to load commit list.
Closed

[PoC] Use Set hash in Distinct #5028

Merge branch 'main' into set-hash
7366740
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Mar 10, 2024 in 0s

83.5% (+0.0%) compared to 2d968c4

View this Pull Request on Codecov

83.5% (+0.0%) compared to 2d968c4

Details

Codecov Report

Attention: Patch coverage is 94.11765% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.5%. Comparing base (2d968c4) to head (7366740).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #5028   +/-   ##
=====================================
  Coverage   83.5%   83.5%           
=====================================
  Files        238     240    +2     
  Lines      15757   15832   +75     
=====================================
+ Hits       13159   13229   +70     
- Misses      2309    2314    +5     
  Partials     289     289
Files Coverage Δ
attribute/internal/fnv/fnv.go 100.0% <100.0%> (ø)
attribute/set.go 78.0% <96.5%> (-0.3%) ⬇️
attribute/hash.go 89.1% <89.1%> (ø)

... and 1 file with indirect coverage changes

View more details on Codecov