New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exporters/otlp/otlptrace: fix incorrect documentation #5098
base: main
Are you sure you want to change the base?
exporters/otlp/otlptrace: fix incorrect documentation #5098
Conversation
58e0174
to
ecca3a6
Compare
9fb0065
to
44b4a25
Compare
Apologies, you may want to do a re-review here, also I am having some difficulty with the
|
44b4a25
to
acea9fa
Compare
// WithEndpoint configures the trace host and port only; endpoint should | ||
// resemble "example.com" or "localhost:4317". To configure the scheme and path, | ||
// use WithEndpointURL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this more consistent, like
// WithEndpoint configures the trace host and port only; endpoint should | |
// resemble "example.com" or "localhost:4317". To configure the scheme and path, | |
// use WithEndpointURL. | |
// WithEndpoint sets the target endpoint (host and port) the Exporter will | |
// connect to. The provided endpoint should resemble "example.com:4318" (no | |
// scheme or path). |
// WithEndpointURL configures the trace scheme, host, port, and path; the | ||
// provided value should resemble "https://example.com:4318/v1/traces". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5098 +/- ##
=====================================
Coverage 84.5% 84.5%
=====================================
Files 258 258
Lines 17096 17096
=====================================
+ Hits 14452 14454 +2
+ Misses 2345 2343 -2
Partials 299 299
|
@XSAM Are you OK if I just resolve your comments and merge the PR as it is? |
No description provided.