Use empty resource when RecordFactory.Resource is nil
#5264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:testing
MrAlias
force-pushed
the
empty-res-logtest
branch
from
86bbf6c
to
fab2296
Compare
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
XSAM
approved these changes
Apr 25, 2024
pellared
approved these changes
Apr 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5264 +/- ##
=======================================
- Coverage 84.4% 84.4% -0.1%
=======================================
Files 265 265
Lines 17477 17480 +3
=======================================
+ Hits 14755 14757 +2
- Misses 2411 2412 +1
Partials 311 311
|
|
Should there be a test? |
hanyuancheung
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing, a dev will expect a zero value when they provide a zero value. Do not use the default resource from the SDK when the zero value of the
Resourcefield is provided.