Use sync.Pools for ResourceLogs in otelloghttp transforms #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroyaonoe
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
hiroyaonoe
force-pushed
the
resource-logs-pool
branch
from
e4f5cfa
to
646a771
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5268 +/- ##
======================================
Coverage 84.3% 84.4%
======================================
Files 258 265 +7
Lines 17042 17483 +441
======================================
+ Hits 14382 14759 +377
- Misses 2361 2413 +52
- Partials 299 311 +12
|
|
Please show how the performance is improved with this change with benchmarks. |
MrAlias
reviewed
Apr 26, 2024
| LogRecords: pbLogRecords[2:], | ||
| }}, | ||
| }} | ||
| out, free = ResourceLogs(records[2:]) |
There was a problem hiding this comment.
free is never called here.
MrAlias
reviewed
Apr 26, 2024
| @@ -18,18 +19,26 @@ import ( | |||
| "go.opentelemetry.io/otel/sdk/log" | |||
| ) | |||
|
|
|||
| // ResourceLogs returns an slice of OTLP ResourceLogs generated from records. | |||
| func ResourceLogs(records []log.Record) []*lpb.ResourceLogs { | |||
| var resourceLogsPool = sync.Pool{ | |||
There was a problem hiding this comment.
These pool values escape this package. It is likely a better design to have pooled values passed to ResourceLogs instead so leaks are not incurred.
MrAlias
added
area:logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used
sync.Poolsto pool the slice[]*lpb.ResourceLogs. The functionfree, whichResourceLogsreturns, puts the slice into the pools.Also, I updated the test
TestResourceLogsfor the data integrity.I referred to https://github.com/open-telemetry/opentelemetry-go-contrib/blob/59ebbee5c207bb6034462a75da61b79668fe9232/bridges/otelslog/handler.go#L346