-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of otlploggrpc configuration #5383
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5383 +/- ##
=======================================
+ Coverage 84.6% 84.8% +0.2%
=======================================
Files 268 268
Lines 17852 18037 +185
=======================================
+ Hits 15111 15311 +200
+ Misses 2428 2407 -21
- Partials 313 319 +6
|
Keep in mind that I am not sure if this would be worth the effort given these configs are not 1:1. |
Two things I think we can make as a shared template in the following PRs:
|
part of #5056
Most of the codes are copied from
otlploghttp
.I will try to make
internal/conf
as a shared go template file sootlploghttp
can use a shared setting struct withotlploggrpc
in the following PRs.