Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] append to otel resource attributes #1059

Merged

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Mar 2, 2024

Allows users to completely override the OTEL_RESOURCE_ATTRIBUTES environment variable at the component level or append to it using a special OTEL_RESOURCE_ATTRIBUTES_EXTRA environment variable.

Users can now specify:

components:
  frontendProxy:
    envOverrides:
      - name: OTEL_RESOURCE_ATTRIBUTES_EXTRA
        value: "net.component=proxy"

And the resource attributes for the frontendProxy will also contain a net.component=proxy attrbribute.

Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck puckpuck requested a review from a team as a code owner March 2, 2024 05:20
@TylerHelmuth TylerHelmuth merged commit 1691148 into open-telemetry:main Mar 11, 2024
3 checks passed
@puckpuck puckpuck deleted the demo.otel-resource-attributes-extra branch March 19, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants