-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[demo] Remove FeatureFlagService and add flagd #1082
[demo] Remove FeatureFlagService and add flagd #1082
Conversation
@puckpuck you mention in the I've updated opensearch, but I couldn't find where to update it on Grafana datasource. |
Line 809 of the values file for the Helm chart. I'm on PTO using my phone so apologies for the short message. |
Thank you! |
Hey @TylerHelmuth 👋🏽 Do you happen to know what am I doing wrong here? |
For me the flagd container just runs and exits as if no config has been specified. Configmap appears to be mounted at /etc/flagd. Below is the output I get when looking at the flagd container logs.
|
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
# Conflicts: # charts/opentelemetry-demo/Chart.yaml # charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/component.yaml # charts/opentelemetry-demo/examples/bring-your-own-observability/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/component.yaml # charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/collector-as-daemonset/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/custom-environment-variables/rendered/component.yaml # charts/opentelemetry-demo/examples/custom-environment-variables/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/custom-environment-variables/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/default/rendered/component.yaml # charts/opentelemetry-demo/examples/default/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/default/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/component.yaml # charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/kubernetes-infra-monitoring/rendered/serviceaccount.yaml # charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/component.yaml # charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/grafana-dashboards.yaml # charts/opentelemetry-demo/examples/public-hosted-ingress/rendered/serviceaccount.yaml
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@julianocosta89 I pushed a commit to your branch to get flagd working. There were a few small other issues, but the main one was having to specify the command arguments. This did bring up an interesting point. Right now we have 2 environment variables, |
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@puckpuck I actually started doing that, but glad doesn't support it. https://flagd.dev/reference/specifications/in-process-providers/?h=environmen#explicit-declaration I'm on the phone so the link may not be pointing to the right place, but check out the environment variables in this page. |
BTW, thanks for taking a look and fixing the PR |
Would we be able to get this merged? |
We need the demo to cut a release first, then we can target those images in this Helm chart to ensure all CI tests pass. |
@puckpuck this one should be good to go! 🥳 |
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
Signed-off-by: Pierre Tessier <pierre@pierretessier.com>
@julianocosta89 I updated NOTES.txt to remove references to the old feature flag UI, and replaced demo.flagd.json with the same from the demo repo to ensure they are the same. Everything looks good! |
The PR open-telemetry/opentelemetry-demo#1388 removed FeatureFlag Service and replaced it with flagd.
This PR updates the charts to reflect the latest changes on the demo.
It also updates the dependencies charts.