Allow WATCH_NAMESPACE as manager.env

[janario]

This will allow to add extra WATCH_NAMESPACE env var to the manager, since it is a known env var https://github.com/open-telemetry/opentelemetry-operator/blob/main/main.go#L225C41-L225C56

[TylerHelmuth]

@janario can you confirm via local testing that the manager.env is usable after this change?

[janario]

@janario can you confirm via local testing that the manager.env is usable after this change?

I tested it with the template.

I based it from here: https://swagger.io/docs/specification/data-models/dictionaries/ :-)

... a string-to-string dictionary like this...

---

no custom values: ✅

# helm template -s templates/deployment.yaml ./ | grep -B 3 -A 10 env

          env:
            - name: ENABLE_WEBHOOKS
              value: "true"

Allowed values: ✅

# values-test.yaml
manager:
  env:
    DQUOTE: "my-ns"
    DQUOTE2: "my-ns,my-ns2"
    SQUOTE: 'my-ns'
    SQUOTE2: 'my-ns,my-ns2'
    TEXT: my-ns
    TEXT2: my-ns,my-ns2
    WNUMBER: "1"
    WNUMBER2: '1'
    WBOOL: "true"
    WBOOL2: 'true'
---
# helm template -s templates/deployment.yaml -f values-test.yaml ./ | grep -B 3 -A 25 env
          env:
            - name: DQUOTE
              value: "my-ns"
            - name: DQUOTE2
              value: "my-ns,my-ns2"
            - name: ENABLE_WEBHOOKS
              value: "true"
            - name: SQUOTE
              value: "my-ns"
            - name: SQUOTE2
              value: "my-ns,my-ns2"
            - name: TEXT
              value: "my-ns"
            - name: TEXT2
              value: "my-ns,my-ns2"
            - name: WBOOL
              value: "true"
            - name: WBOOL2
              value: "true"
            - name: WNUMBER
              value: "1"
            - name: WNUMBER2
              value: "1"

And invalid ones: as expected ✅

manager:
  env:
    OBJ: {}
    ARR: []
    NUMBER: 1
    BOOL: true
---
# helm template -s templates/deployment.yaml -f values-test.yaml ./ 
Error: values don't meet the specifications of the schema(s) in the following chart(s):
opentelemetry-operator:
- manager.env.ARR: Invalid type. Expected: string, given: array
- manager.env.BOOL: Invalid type. Expected: string, given: boolean
- manager.env.NUMBER: Invalid type. Expected: string, given: integer
- manager.env.OBJ: Invalid type. Expected: string, given: object

---

Some other specific case that you would like to test? 🤔

[janario]

Thanks a lot for the quick review and support with it.

We will soon upgrade our chart usage ;-)