Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #1151

Merged
merged 4 commits into from
May 6, 2024
Merged

Fix typo #1151

merged 4 commits into from
May 6, 2024

Conversation

jdiegosierra
Copy link
Contributor

No description provided.

@jdiegosierra jdiegosierra requested review from Allex1 and a team as code owners April 18, 2024 12:44
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 18, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@TylerHelmuth
Copy link
Member

Hello, thank your for these changes. Please sign the CLA so we can proceed.

@JaredTan95
Copy link
Member

I'm not sure if this kind of change would require bump up to the chart version? cc @TylerHelmuth

@TylerHelmuth
Copy link
Member

@JaredTan95 any change inside a chart folder require a version change.

@JaredTan95
Copy link
Member

@jdiegosierra pls following Contributing.md guide to polish this PR, in general, you need to bump up operator chart version and CHARTS=opentelemetry-operator make generate-examples .

@JaredTan95
Copy link
Member

@jdiegosierra any update?

@jdiegosierra
Copy link
Contributor Author

@JaredTan95 Thank you for the info and sorry, I'll have a look today.

@jdiegosierra
Copy link
Contributor Author

@TylerHelmuth done :)

@jdiegosierra
Copy link
Contributor Author

@TylerHelmuth any idea of why those test are failing? Is happening the same in my other PR #1170

@TylerHelmuth
Copy link
Member

Likely a flaky test

@TylerHelmuth TylerHelmuth merged commit 51cf9e1 into open-telemetry:main May 6, 2024
3 checks passed
@jdiegosierra jdiegosierra deleted the fix-typo branch May 6, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@Allex1 Allex1 Awaiting requested review from Allex1 Allex1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdiegosierra @TylerHelmuth @JaredTan95 @codeboten @jaronoff97