Add extension functions for Ktor plugins #10963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Mar 29, 2024
trask
reviewed
Apr 4, 2024
Comment on lines
43
to
55
| fun capturedRequestHeaders(vararg headers: String) { | ||
| capturedRequestHeaders(headers.asIterable()) | ||
| } | ||
|
|
||
| fun capturedRequestHeaders(headers: Iterable<String>) { | ||
| setCapturedRequestHeaders(headers.toList()) | ||
| } | ||
|
|
||
| fun setCapturedResponseHeaders(vararg headers: String) = setCapturedResponseHeaders(headers.asList()) | ||
|
|
||
| fun setCapturedResponseHeaders(headers: List<String>) { | ||
| httpAttributesExtractorBuilder.setCapturedResponseHeaders(headers) | ||
| } |
There was a problem hiding this comment.
@marychatte would it make sense to deprecate the set*() methods?
There was a problem hiding this comment.
Yes, thanks. I will do it
laurit
approved these changes
Apr 26, 2024
|
Hi! I just wanted to ask if there are any estimates when the PR can be merged? |
|
hey @marychatte! sorry for the delay, just merged and it will be included in the upcoming release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10617
Earlier, an issue about adding extension functions for plugins that allow writing existing code in the Ktor DSL style was opened.
In this PR, such new functions were added.
These new functions we used in the example where also can be found examples of usages new functions for server and client