Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header values are be expected to be W3C baggage encoded #6164

Merged
merged 6 commits into from Feb 1, 2024

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Jan 18, 2024

@zeitlinger zeitlinger requested a review from a team as a code owner January 18, 2024 13:38
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4407ee7) 90.99% compared to head (5c4b4dd) 90.99%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6164      +/-   ##
============================================
- Coverage     90.99%   90.99%   -0.01%     
- Complexity     5646     5673      +27     
============================================
  Files           619      620       +1     
  Lines         16443    16542      +99     
  Branches       1663     1683      +20     
============================================
+ Hits          14963    15052      +89     
+ Misses         1017     1013       -4     
- Partials        463      477      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zeitlinger
Copy link
Member Author

zeitlinger commented Jan 18, 2024

@jack-berg
Copy link
Member

@jack-berg can this error be ignored?

Yes and no. The codecov target is a goal, not a strict requirement. Sometimes its not practical to have all the code paths covered. Although in this case it seems like it should be straight forward to trigger than exception, no?

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix. Looks good, but let's try to cover the exception case.

zeitlinger and others added 3 commits January 19, 2024 08:29
…p/internal/OtlpConfigUtil.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
…p/internal/OtlpConfigUtil.java

Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
@zeitlinger
Copy link
Member Author

Thanks for the bug fix. Looks good, but let's try to cover the exception case.

Fond a way 😄

@jack-berg
Copy link
Member

Waiting to merge until its clear whether this is going to be considered a breaking change or a bug fix based on this spec conversation: open-telemetry/opentelemetry-specification#3832

@jack-berg jack-berg merged commit ecbd1f9 into open-telemetry:main Feb 1, 2024
18 checks passed
@zeitlinger zeitlinger deleted the header-format branch February 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants