This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
chore: reuse NoopTracer in ProxyTracer #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a single NoopTracer and reuse it in ProxyTracer to avoid creation of a new NoopTracer on every startSpan() call in case no SDK is present.
Flarna
requested review from
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
vmarchaud
approved these changes
Jul 12, 2021
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 94.89% 94.90%
=======================================
Files 42 42
Lines 568 569 +1
Branches 89 89
=======================================
+ Hits 539 540 +1
Misses 29 29
Continue to review full report at Codecov.
|
rauno56
approved these changes
Jul 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a single
NoopTracerand reuse it inProxyTracerto avoid creation of a newNoopTraceron everystartSpan()call in case no SDK is present.