This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
docs: fix rendering of tracer.startActiveSpan examples #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trentm
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Flarna
approved these changes
Jul 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 94.89% 94.89%
=======================================
Files 42 42
Lines 568 568
Branches 89 89
=======================================
Hits 539 539
Misses 29 29 Continue to review full report at Codecov.
|
naseemkullah
approved these changes
Jul 24, 2021
There was a problem hiding this comment.
lgtm, but seems to be a dupe of #101
happy to see either of these merged
Ah, I hadn't looked. Thanks for finding the dupe. Likewise I'm happy for either one to get merged. |
johnbley
approved these changes
Jul 26, 2021
|
Dupe of #101 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (at https://open-telemetry.github.io/opentelemetry-js-api/interfaces/tracer.html):
after:
https://typedoc.org/guides/doccomments/ doesn't document the
@exampletag that I could see, so this is a guess that it meets the requirements to get picked up as a code block (given Markdown requires 4 leading spaces for that).