This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Add CodeQL Security Scan #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxyr
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 42 42
Lines 567 567
Branches 94 94
=======================================
Hits 537 537
Misses 30 30 Continue to review full report at Codecov.
|
dyladan
reviewed
May 20, 2021
vmarchaud
approved these changes
May 21, 2021
naseemkullah
approved these changes
May 21, 2021
|
lgtm 🔐 |
johnbley
approved these changes
May 21, 2021
dyladan
approved these changes
May 24, 2021
|
Out of date branch and maintainers don't have permission to write to the source branch so I can't merge this until it is updated. |
|
Rebased! |
|
@xukaren Sorry but you will need to rebase again :/ Could you allow us to write on your fork so we don't need to bother you in the future ? |
|
@xukaren Thanks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow up to issue open-telemetry/oteps#144
CodeQL is GitHub's static analysis engine which scans repos for security vulnerabilities. As the project grows and we near GA it might be useful to have a workflow which checks for security vulnerabilities with every PR so we can ensure every incremental change is following best development practices. Also passing basic security checks will also make sure that there aren't any glaring issues for our users.
Changes
This PR adds CodeQL security checks to the repo
Workflow Triggers
cc- @alolita