This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
chore: function overloads implementation of startActiveSpan in noop t… #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…racer Signed-off-by: naseemkullah <naseem@transit.app>
naseemkullah
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 94.72% 94.83% +0.10%
==========================================
Files 42 42
Lines 569 561 -8
Branches 96 88 -8
==========================================
- Hits 539 532 -7
+ Misses 30 29 -1
Continue to review full report at Codecov.
|
added 3 commits
May 21, 2021 20:39
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
Signed-off-by: naseemkullah <naseem@transit.app>
vmarchaud
approved these changes
May 22, 2021
Flarna
approved these changes
May 22, 2021
dyladan
reviewed
May 24, 2021
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
vmarchaud
approved these changes
May 25, 2021
Could someone with authority please merge? |
on api repo we want all maintainers to approve. |
dyladan
approved these changes
Jun 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…racer
Signed-off-by: naseemkullah naseem@transit.app