fix(instr-knex): set correct SpanKind for traces (#2157)

Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
open-telemetry · Apr 29, 2024 · 2d07c18 · 2d07c18
1 parent b40926e
commit 2d07c18
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/plugins/node/opentelemetry-instrumentation-knex/src/instrumentation.ts b/plugins/node/opentelemetry-instrumentation-knex/src/instrumentation.ts
@@ -160,6 +160,7 @@ export class KnexInstrumentation extends InstrumentationBase {
         const span = instrumentation.tracer.startSpan(
           utils.getName(name, operation, table),
           {
+            kind: api.SpanKind.CLIENT,
             attributes,
           },
           parent

diff --git a/plugins/node/opentelemetry-instrumentation-knex/test/index.test.ts b/plugins/node/opentelemetry-instrumentation-knex/test/index.test.ts
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { context, trace } from '@opentelemetry/api';
+import { SpanKind, context, trace } from '@opentelemetry/api';
 import { NodeTracerProvider } from '@opentelemetry/sdk-trace-node';
 import { AsyncHooksContextManager } from '@opentelemetry/context-async-hooks';
 import {
@@ -471,6 +471,7 @@ const assertSpans = (actualSpans: any[], expectedSpans: any[]) => {
     try {
       assert.notStrictEqual(span, undefined);
       assert.notStrictEqual(expected, undefined);
+      assert.strictEqual(span.kind, SpanKind.CLIENT);
       assertMatch(span.name, new RegExp(expected.op));
       assertMatch(span.name, new RegExp(':memory:'));
       assert.strictEqual(span.attributes['db.system'], 'sqlite');