Skip to content

Commit

Permalink
chore(examples/connect): use exported strings for attributes (#2120)
Browse files Browse the repository at this point in the history
Use exported strings for Semantic Resource Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Refs: #2025
  • Loading branch information
maryliag committed Apr 24, 2024
1 parent 5f1910b commit 77452c1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion examples/connect/package.json
Expand Up @@ -45,7 +45,7 @@
"@opentelemetry/instrumentation-http": "^0.25.0",
"@opentelemetry/sdk-trace-node": "^0.25.0",
"@opentelemetry/resources": "^0.25.0",
"@opentelemetry/semantic-conventions": "^0.25.0",
"@opentelemetry/semantic-conventions": "^1.23.0",
"@opentelemetry/sdk-trace-base": "^0.25.0",
"axios": "^0.21.1",
"cross-env": "^7.0.3",
Expand Down
4 changes: 2 additions & 2 deletions examples/connect/tracing.js
Expand Up @@ -6,7 +6,7 @@ const { diag, DiagConsoleLogger, DiagLogLevel } = opentelemetry;
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.INFO);

const { Resource } = require('@opentelemetry/resources');
const { ResourceAttributes: SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions');
const { registerInstrumentations } = require('@opentelemetry/instrumentation');
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
const { SimpleSpanProcessor } = require('@opentelemetry/sdk-trace-base');
Expand All @@ -24,7 +24,7 @@ function log() {
module.exports = (serviceName) => {
const provider = new NodeTracerProvider({
resource: new Resource({
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
[SEMRESATTRS_SERVICE_NAME]: serviceName,
}),
});
const connectInstrumentation = new ConnectInstrumentation();
Expand Down

0 comments on commit 77452c1

Please sign in to comment.