chore: fixing express example (#573)

open-telemetry · Jul 16, 2021 · 9668b42 · 9668b42
1 parent 9dabf39
commit 9668b42
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/examples/express/package.json b/examples/express/package.json
@@ -32,8 +32,10 @@
     "@opentelemetry/exporter-jaeger": "^0.23.0",
     "@opentelemetry/exporter-zipkin": "^0.23.0",
     "@opentelemetry/instrumentation": "^0.23.0",
-    "@opentelemetry/instrumentation-express": "^0.15.0",
+    "@opentelemetry/instrumentation-express": "^0.23.0",
     "@opentelemetry/instrumentation-http": "^0.23.0",
+    "@opentelemetry/resources": "^0.23.0",
+    "@opentelemetry/semantic-conventions": "^0.23.0",
     "@opentelemetry/node": "^0.23.0",
     "@opentelemetry/tracing": "^0.23.0",
     "axios": "^0.21.1",

diff --git a/examples/express/tracer.js b/examples/express/tracer.js
@@ -11,14 +11,20 @@ const { NodeTracerProvider } = require('@opentelemetry/node');
 const { SimpleSpanProcessor } = require('@opentelemetry/tracing');
 const { JaegerExporter } = require('@opentelemetry/exporter-jaeger');
 const { ZipkinExporter } = require('@opentelemetry/exporter-zipkin');
+const { Resource } = require('@opentelemetry/resources');
+const { ResourceAttributes: ResourceAttributesSC } = require('@opentelemetry/semantic-conventions');
 
 const Exporter = (process.env.EXPORTER || '')
   .toLowerCase().startsWith('z') ? ZipkinExporter : JaegerExporter;
 const { ExpressInstrumentation } = require('@opentelemetry/instrumentation-express');
 const { HttpInstrumentation } = require('@opentelemetry/instrumentation-http');
 
 module.exports = (serviceName) => {
-  const provider = new NodeTracerProvider();
+  const provider = new NodeTracerProvider({
+    resource: new Resource({
+      [ResourceAttributesSC.SERVICE_NAME]: serviceName,
+    }),
+  });
   registerInstrumentations({
     tracerProvider: provider,
     instrumentations: [