Skip to content

Commit

Permalink
chore(examples/memcached): use exported strings for attributes (#2124)
Browse files Browse the repository at this point in the history
Use exported strings for Semantic Attributes

Signed-off-by: maryliag <marylia.gutierrez@grafana.com>
Refs: #2025
  • Loading branch information
maryliag committed Apr 25, 2024
1 parent 4a4a087 commit e04362a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion examples/memcached/package.json
Expand Up @@ -31,8 +31,10 @@
"@opentelemetry/api": "^1.0.2",
"@opentelemetry/instrumentation": "^0.25.0",
"@opentelemetry/instrumentation-memcached": "^0.23.0",
"@opentelemetry/sdk-trace-node": "^0.25.0",
"@opentelemetry/resources": "^1.23.0",
"@opentelemetry/sdk-trace-base": "^0.25.0",
"@opentelemetry/sdk-trace-node": "^0.25.0",
"@opentelemetry/semantic-conventions": "^1.23.0",
"memcached": "^2.2.2"
},
"homepage": "https://github.com/open-telemetry/opentelemetry-js-contrib#readme"
Expand Down
4 changes: 2 additions & 2 deletions examples/memcached/tracer.js
Expand Up @@ -9,14 +9,14 @@ const { registerInstrumentations } = require('@opentelemetry/instrumentation');
const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
const { SimpleSpanProcessor, ConsoleSpanExporter } = require('@opentelemetry/sdk-trace-base');
const { Resource } = require('@opentelemetry/resources');
const { SemanticResourceAttributes } = require('@opentelemetry/semantic-conventions');
const { SEMRESATTRS_SERVICE_NAME } = require('@opentelemetry/semantic-conventions');

const { MemcachedInstrumentation } = require('@opentelemetry/instrumentation-memcached');

module.exports = (serviceName) => {
const provider = new NodeTracerProvider({
resource: new Resource({
[SemanticResourceAttributes.SERVICE_NAME]: serviceName,
[SEMRESATTRS_SERVICE_NAME]: serviceName,
}),
});
registerInstrumentations({
Expand Down

0 comments on commit e04362a

Please sign in to comment.