Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knex instrumentation is definining span.kind as internal #1839

Closed
marin-h opened this issue Dec 1, 2023 · 1 comment · Fixed by #2157
Closed

knex instrumentation is definining span.kind as internal #1839

marin-h opened this issue Dec 1, 2023 · 1 comment · Fixed by #2157
Assignees
@david-luna
Labels
bug Something isn't working pkg:instrumentation-knex priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect

Comments

@marin-h
Copy link

marin-h commented Dec 1, 2023 •
edited

What version of OpenTelemetry are you using?

    "@opentelemetry/api": "^1.4.0",
    "@opentelemetry/core": "^1.9.0",
    "@opentelemetry/exporter-metrics-otlp-grpc": "^0.35.0",
    "@opentelemetry/exporter-trace-otlp-grpc": "^0.35.0",
    "@opentelemetry/id-generator-aws-xray": "^1.1.1",
    "@opentelemetry/instrumentation": "^0.35.0",
    "@opentelemetry/instrumentation-aws-lambda": "^0.34.0",
    "@opentelemetry/instrumentation-aws-sdk": "^0.33.0",
    "@opentelemetry/instrumentation-express": "^0.32.0",
    "@opentelemetry/instrumentation-http": "^0.35.0",
    "@opentelemetry/instrumentation-knex": "^0.31.0",
    "@opentelemetry/instrumentation-nestjs-core": "^0.32.0",
    "@opentelemetry/instrumentation-net": "^0.31.0",
    "@opentelemetry/instrumentation-winston": "^0.31.0",
    "@opentelemetry/otlp-transformer": "^0.35.0",
    "@opentelemetry/propagator-aws-xray": "^1.1.1",
    "@opentelemetry/resource-detector-aws": "^1.2.1",
    "@opentelemetry/resource-detector-container": "^0.2.1",
    "@opentelemetry/resources": "^1.9.0",
    "@opentelemetry/sdk-metrics": "^1.9.0",
    "@opentelemetry/sdk-trace-base": "^1.9.0",
    "@opentelemetry/sdk-trace-node": "^1.9.0",
    "@opentelemetry/semantic-conventions": "^1.9.0",

What version of Node are you using?

16.20.2

What did you do?

Using @opentelemetry/instrumentation-knex to instrument our database queries.

What did you expect to see?

Knex spans should have span.kind as client.

What did you see instead?

Knex spans have span.kind as internal (default value).
@marin-h marin-h added the bug Something isn't working label Dec 1, 2023
@pichlermarc pichlermarc added priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect pkg:instrumentation-knex labels Jan 10, 2024
@david-luna david-luna self-assigned this Apr 26, 2024
@david-luna
Copy link
Contributor

Hi @marin-h

you're right. Knex is not setting the span kind value when starting the span so it defaults to internal.

opentelemetry-js-contrib/plugins/node/opentelemetry-instrumentation-knex/src/instrumentation.ts

Line 163 in 7822461

attributes,

This should be easy to fix :)

@david-luna david-luna mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-luna david-luna

Labels
bug Something isn't working pkg:instrumentation-knex priority:p2 Bugs and spec inconsistencies which cause telemetry to be incomplete or incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(instr-knex): set correct SpanKind for traces david-luna/opentelemetry-js-contrib
3 participants
@david-luna @marin-h @pichlermarc