Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instr-knex): set correct SpanKind for traces #2157

Merged

Conversation

david-luna
Copy link
Contributor

Which problem is this PR solving?

  • The span kind is set to default where it should be set to SpanKind.CLIENT

Fixes: #1839

Short description of the changes

  • set span kind to SpanKind.CLIENT when starting it

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (dfb2dff) to head (f540e75).
Report is 84 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
- Coverage   90.97%   90.45%   -0.53%     
==========================================
  Files         146      147       +1     
  Lines        7492     7576      +84     
  Branches     1502     1574      +72     
==========================================
+ Hits         6816     6853      +37     
- Misses        676      723      +47     
Files Coverage Δ
...emetry-instrumentation-knex/src/instrumentation.ts 98.71% <ø> (-0.07%) ⬇️

... and 26 files with indirect coverage changes

@blumamir blumamir merged commit 2d07c18 into open-telemetry:main Apr 29, 2024
17 checks passed
@dyladan dyladan mentioned this pull request Apr 29, 2024
@david-luna david-luna deleted the dluna/1839-knex-span-kind-client branch May 2, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

knex instrumentation is definining span.kind as internal
3 participants