Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] newly created packages are published before the release PR is merged #2020

Closed
pichlermarc opened this issue Mar 18, 2024 · 6 comments · Fixed by #2133 or #2160
Closed

[ci] newly created packages are published before the release PR is merged #2020

pichlermarc opened this issue Mar 18, 2024 · 6 comments · Fixed by #2133 or #2160
Assignees
@JamieDanielson
Labels
bug Something isn't working internal priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization

Comments

@pichlermarc
Copy link
Member

There seems to be a bug in our release pipeline where newly created packages are published before a release PR is merged. We should guard in our workflow so that it only releases on commits that are created by a release PR.

I've noticed this as the @opentelemetry/winston-transport package was published without an associated release PR.

Resources:
@pichlermarc pichlermarc added bug Something isn't working internal priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization labels Mar 18, 2024
@JamieDanielson JamieDanielson mentioned this issue Apr 19, 2024
Merged
@JamieDanielson
Copy link
Member

Hmm these docs look promising. Think we just need to add if: ${{ steps.release.outputs.release_created }} to the workflow step. I'll open a PR for it

@JamieDanielson JamieDanielson self-assigned this Apr 19, 2024
@JamieDanielson JamieDanielson mentioned this issue Apr 19, 2024
Merged
@pichlermarc pichlermarc reopened this Apr 25, 2024
@pichlermarc pichlermarc mentioned this issue Apr 25, 2024
Merged
@pichlermarc
Copy link
Member Author

re-opened as that unfortunately did not fix it :/

@pichlermarc
Copy link
Member Author

I think it should've probably been releases_created instead of release_created (root-component vs non-root-component)

@JamieDanielson
Copy link
Member

Ah darn! 😢

@pichlermarc
Copy link
Member Author

@JamieDanielson do you want to give it another shot? 🙂
You originally found out how to do it - I think it'd work with releases_created 🙂

releases_created -> true if any release was created, false otherwise
release_created -> true if a root component release was created, false otherwise

@JamieDanielson JamieDanielson mentioned this issue Apr 26, 2024
Merged
@pichlermarc
Copy link
Member Author

The solution from #2160 works 🙂 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamieDanielson JamieDanielson

Labels
bug Something isn't working internal priority:p4 Bugs and spec inconsistencies which do not fall into a higher prioritization
Projects
None yet
Milestone
No milestone
2 participants
@pichlermarc @JamieDanielson