Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): rollback #2133 #2148

Merged

Conversation

pichlermarc
Copy link
Member

rolls back #2133 as the release workflow is now not working anymore (step output does not work correctly)?

Reopens #2020

@pichlermarc pichlermarc marked this pull request as ready for review April 25, 2024 18:20
@pichlermarc pichlermarc requested a review from a team as a code owner April 25, 2024 18:20
@pichlermarc
Copy link
Member Author

should've probably been releases_created instead of release_created (release would be a root component according to the docs)

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (dfb2dff) to head (9d33583).
Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   90.97%   90.45%   -0.53%     
==========================================
  Files         146      147       +1     
  Lines        7492     7576      +84     
  Branches     1502     1574      +72     
==========================================
+ Hits         6816     6853      +37     
- Misses        676      723      +47     

see 24 files with indirect coverage changes

@pichlermarc pichlermarc merged commit 96a87b4 into open-telemetry:main Apr 25, 2024
15 checks passed
@dyladan dyladan deleted the fix/release-broken branch April 25, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants