Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix lint #1355

Merged
merged 1 commit into from Jan 15, 2023
Merged

ci: fix lint #1355

merged 1 commit into from Jan 15, 2023

Conversation

blumamir
Copy link
Member

CI currently fails on lint workflow for a few days, and we can't merge approved PRs. I guess some transitive dependency was updated and change the prettier config/functioning.

I do not have time to understand where it comes from, but run lint:fix on the repo to make CI green again.

@blumamir blumamir requested a review from a team as a code owner January 15, 2023 15:07
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with these changes anyway

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #1355 (c1cc647) into main (8b8bfeb) will decrease coverage by 0.36%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
- Coverage   96.08%   95.72%   -0.37%     
==========================================
  Files          14       22       +8     
  Lines         893     1472     +579     
  Branches      191      300     +109     
==========================================
+ Hits          858     1409     +551     
- Misses         35       63      +28     
Impacted Files Coverage Δ
...tapackages/auto-instrumentations-node/src/utils.ts 98.21% <ø> (ø)
...etapackages/auto-instrumentations-web/src/utils.ts 95.83% <ø> (ø)
.../instrumentation-dataloader/src/instrumentation.ts 99.01% <ø> (ø)
...etry-instrumentation-graphql/src/internal-types.ts 100.00% <ø> (ø)
...try-instrumentation-graphql/src/instrumentation.ts 92.85% <0.00%> (ø)
...nstrumentation-graphql/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-graphql/src/symbols.ts 100.00% <0.00%> (ø)
.../opentelemetry-instrumentation-graphql/src/enum.ts 100.00% <0.00%> (ø)
... and 2 more

@blumamir
Copy link
Member Author

Looks like it's related to this PR in prettier, which now requires parentheses around typeof x. This was published as patch version 2.8.2 which was picked up by gts that has a caret range dependency on prettier.

I guess it should have been considered a breaking change and published on a major version, but maybe prettier uses a different workflow. Anyway it is fixed now in this repo

@blumamir blumamir merged commit 714e6c1 into open-telemetry:main Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants