Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(instrumentation-nestjs-core): extract reusable span attributes to outer scope #2087

Merged
merged 3 commits into from Apr 29, 2024

Conversation

Samuron
Copy link
Contributor

@Samuron Samuron commented Apr 5, 2024

Which problem is this PR solving?

Reduce overhead of nestjs instrumentation

Short description of the changes

Pulled some parts of instrumentation to enclosing scope to reuse and reduce allocations

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.68%. Comparing base (dfb2dff) to head (2f82d70).
Report is 89 commits behind head on main.

❗ Current head 2f82d70 differs from pull request most recent head 1b18180. Consider uploading reports for the commit 1b18180 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   90.97%   95.68%   +4.70%     
==========================================
  Files         146       11     -135     
  Lines        7492      788    -6704     
  Branches     1502      164    -1338     
==========================================
- Hits         6816      754    -6062     
+ Misses        676       34     -642     

see 136 files with indirect coverage changes

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution

@blumamir blumamir merged commit 405472d into open-telemetry:main Apr 29, 2024
15 checks passed
@dyladan dyladan mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants