Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/ioredis4 to v5 #2093

Closed

Conversation

renovate-bot
Copy link
Contributor

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@​types/ioredis4 4.28.10 -> 5.0.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "before 3am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@forking-renovate forking-renovate bot added the dependencies Pull requests that update a dependency file label Apr 12, 2024
@renovate-bot renovate-bot requested a review from a team as a code owner April 12, 2024 02:45
@blumamir
Copy link
Member

The new package suggested is just a stub:

This package has been deprecated

Author message:

This is a stub types definition. ioredis provides its own type definitions, so you do not need this installed.
@types/ioredis
5.0.0 • Public • Published 2 years ago

Since the package does import from the types package at the moment, this change would break the instrumentation and cannot work for us.

We might want to choose a different typing strategy for instrumentations patches and drop any dependency on types from the definitely typed project, but there is no reason to keep this PR open at the moment.

@blumamir blumamir closed this Apr 29, 2024
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/ioredis4-5.x branch April 29, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pkg:instrumentation-ioredis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants